Skip to content

Move Cucumber-related classes to a separate package #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Move Cucumber-related classes to a separate package #850

wants to merge 2 commits into from

Conversation

olithin
Copy link

@olithin olithin commented Feb 16, 2018

Addressed to #648

@olithin olithin requested a review from php-coder as a code owner February 16, 2018 06:04
@olithin olithin changed the title Cucumber-related classes to a separate package moved 648_Cucumber-related classes to a separate package moved Feb 16, 2018
@php-coder php-coder changed the title 648_Cucumber-related classes to a separate package moved Move Cucumber-related classes to a separate package Feb 16, 2018
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding a time to work on this!

I left couple comments and also I see that the branch has conflicts that have to be resolved.

@@ -16,7 +16,7 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

package ru.mystamps.web.tests;
package ru.mystamps.web.tests.integration.cucumber;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in ru.mystamps.web.test.integration.cucumber -- tests -> test

@@ -16,7 +16,7 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

package ru.mystamps.web.tests;
package ru.mystamps.web.tests.integration.cucumber.step;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in ru.mystamps.web.test.integration.cucumber.step, tests -> test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants